feat (v18): Modernize Inplace and expand test #16545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 14, 2024 19:22
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
medbenmakhlouf
changed the title
# Conflicts: # src/app/components/inplace/inplace.ts
# Conflicts: # packages/primeng/src/inplace/inplace.spec.ts # packages/primeng/src/inplace/inplace.ts
mertsincan
added
the
Status: Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor:
Updated the Inplace component to leverage Angular's new signal-based inputs for enhanced reactivity and performance optimization.
Test Cases: Added comprehensive test cases to cover:
Dynamic input handling (label, icon, image)
Inline styles and CSS class binding
Size variations (normal, large, xlarge)
Shape variations (square, circle)
Error handling for image loading
Accessibility (aria-label, aria-labelledby)
Custom styling and class inputs (styleClass, style)
Fix issue #16546